| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: s/LABEL/VALUE/ for ENUMs |
| Date: | 2010-11-23 19:48:07 |
| Message-ID: | AANLkTi=+s6bq1n2tFE5=0VKZrbaT2HCm6gcWoDP85bVG@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 23, 2010 at 2:01 PM, David E. Wheeler <david(at)kineticode(dot)com> wrote:
> On Nov 22, 2010, at 6:03 PM, Josh Berkus wrote:
>
>> ... "original patch". Sorry. Let's not fiddle with the names.
>
> To be clear, as things stand now, the new command is:
>
> ALTER TYPE name ADD VALUE new_enum_value [ { BEFORE | AFTER } existing_enum_value ]
>
> So while the term in the SQL statement is "VALUE," it's called a "label" in the documentation. I think that's confusing. Does anyone else?
Yes. As between the two options, I favor changing the command. And
let's also paint it pink.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2010-11-23 19:49:57 | Re: s/LABEL/VALUE/ for ENUMs |
| Previous Message | Alvaro Herrera | 2010-11-23 19:29:03 | Re: patch: fix performance problems with repated decomprimation of varlena values in plpgsql |