Using Test::More test functions for pg_rewind

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Using Test::More test functions for pg_rewind
Date: 2022-02-21 14:10:20
Message-ID: AA527525-F0CC-4AA2-AF98-543CABFDAF59@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

check_query() in RewindTest.pm currently has this comment before handrolling
tests for return code and stderr:

# We don't use ok() for the exit code and stderr, because we want this
# check to be just a single test.

The code came with the initial import of pg_rewind, and there is no further
explanation but I guess it was to make test planning easier since each
check_query would count as 1 test. (inspecting old pre-import pg_rewind repos
on Github didn't given any other insights). Does anymore remember the
rationale for this?

Since we moved to done_testing() with 549ec201d we no longer need be concerned
with test counts, so we can replace this with normal is() tests, as per the
attached, making the output in the errorpath consistent with other tests.
Unless I'm missing something important here.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
0001-Use-test-functions-in-pg_rewind-test-module.patch application/octet-stream 1.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-02-21 14:11:30 Re: Trap errors from streaming child in pg_basebackup to exit early
Previous Message Noboru Saito 2022-02-21 13:23:16 Re: Separate the result of \watch for each query execution (psql)