|From:||Daniel Gustafsson <daniel(at)yesql(dot)se>|
|To:||Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>|
|Subject:||Re: ANALYZE command progress checker|
|Views:||Raw Message | Whole Thread | Download mbox|
> On 05 Apr 2017, at 03:17, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Wed, Apr 5, 2017 at 1:49 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Apr 4, 2017 at 4:57 AM, Amit Langote
>> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> Hmm, you're right. It could be counted with a separate variable
>>> initialized to 0 and incremented every time we decide to add a row to the
>>> final set of sampled rows, although different implementations of
>>> AcquireSampleRowsFunc have different ways of deciding if a given row will
>>> be part of the final set of sampled rows.
>>> On the other hand, if we decide to count progress in terms of blocks as
>>> you suggested afraid, I'm afraid that FDWs won't be able to report the
>> I think it may be time to push this patch out to v11. It was
>> submitted one day before the start of the last CommitFest, the design
>> wasn't really right, and it's not clear even now that we know what the
>> right design is. And we're pretty much out of time.
> We're encountering the design issue and it takes more time to find out
> right design including FDWs support.
I’m marking this patch Returned with Feedback since it has been Waiting for
author during the commitfest without updates.
|Next Message||Vik Fearing||2017-10-01 22:19:33||Logging idle checkpoints|
|Previous Message||Andres Freund||2017-10-01 22:14:47||Re: pg_ctl kill support for KILL signal was Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.|