| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_control_checkpoint(): add "data_checksum_version" (Pg19)? |
| Date: | 2026-08-10 08:13:16 |
| Message-ID: | A8E36600-1F14-4EEE-87BC-0B3E5555B029@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 10 Aug 2026, at 06:14, Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> Commit f19c0eccae adds the data_checksum_version field to the pg_controldata
> output, but there is no matching entry in "pg_control_checkpoint()". I can't
> see any reason why this is omitted (I don't see any mention of it in the
> corresponding -hackers thread [*]) so assume it's not intentional. A similar
> update was made in 99e949f84 for logical decoding status.
Thanks, that was indeed missed in the original commit. I reworked the patch a
tiny bit and added it to the test suite as per the attached v2. Once the
REL_19_STABLE branch is open I'll push this along with a catversion bump.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-data_checksum_state-to-pg_control_checkpoint.patch | application/octet-stream | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-08-10 08:25:39 | Re: [PATCH] Fix TOCTOU races in recovery/t/020_archive_status.pl archive checks |
| Previous Message | Chao Li | 2026-08-10 08:11:38 | Re: Fix detection of truncated zstd-compressed backups |