Re: Don't choke on files that are removed while pg_rewind runs.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Subject: Re: Don't choke on files that are removed while pg_rewind runs.
Date: 2020-07-13 06:34:06
Message-ID: A82A60E9-DF11-4A7D-8742-E99CD917AD87@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 13 Jul 2020, at 08:10, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:

> Every other access to "res" in this loop is to res(i), which I believe is what
> was intended here, too. Currently, it will dumbly loop but skip *every* row if
> the 2nd column (1: size) of the first row (0) is null.

Yeah, I agree with that, seems like the call should've been PQgetisnull(res, i, 1);
to match the loop.

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message movead.li@highgo.ca 2020-07-13 06:46:23 Re: POC and rebased patch for CSN based snapshots
Previous Message Pavel Stehule 2020-07-13 06:15:42 Re: proposal: possibility to read dumped table's name from file