From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | yuzuko <yuzukohosoya(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu> |
Subject: | Re: Autovacuum on partitioned table (autoanalyze) |
Date: | 2020-08-01 21:50:59 |
Message-ID: | A7A3BAC3-4540-4946-8DAE-1D48370E2849@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 6 Jul 2020, at 12:35, yuzuko <yuzukohosoya(at)gmail(dot)com> wrote:
>
>> On Wed, Jul 1, 2020 at 6:26 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 21 Apr 2020, at 18:21, yuzuko <yuzukohosoya(at)gmail(dot)com> wrote:
>>
>>> I'll update the patch soon.
>>
>> Do you have an updated version to submit? The previous patch no longer applies
>> to HEAD, so I'm marking this entry Waiting on Author in the meantime.
>>
> Thank you for letting me know.
> I attach the latest patch applies to HEAD.
This version seems to fail under Werror which is used in the Travis builds:
autovacuum.c: In function ‘relation_needs_vacanalyze’:
autovacuum.c:3117:59: error: ‘reltuples’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
^
autovacuum.c:2972:9: note: ‘reltuples’ was declared here
float4 reltuples; /* pg_class.reltuples */
^
I've moved this patch to the next commitfest, but kept the status as Waiting on
Author. Please submit a new version of the patch.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2020-08-01 22:00:56 | Re: Default gucs for EXPLAIN |
Previous Message | Tom Lane | 2020-08-01 21:27:53 | Re: psql - improve test coverage from 41% to 88% |