From: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
---|---|
To: | "'Tom Lane *EXTERN*'" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "pgsql-hackers(at)postgreSQL(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1 |
Date: | 2016-10-12 13:53:32 |
Message-ID: | A737B7A37273E048B164557ADEF4A58B5393033E@ntex2010a.host.magwien.gv.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
>> PostgreSQL itself seems to use export files that explicitly declare the
>> exported symbols, so it gets away without these decorations.
>
> Except that we don't. There aren't PGDLLEXPORT markings for any
> functions exported from contrib modules, and we don't use dlltool
> on them either. By your argument, none of contrib would work on
> Windows builds at all, but we have a ton of buildfarm evidence and
> successful field use to the contrary. How is that all working?
I thought it was the job of src/tools/msvc/gendef.pl to generate
.DEF files? In the buildfarm logs I can find lines like:
Generating CITEXT.DEF from directory Release\citext, platform x64
Generating POSTGRES_FDW.DEF from directory Release\postgres_fdw, platform x64
which are emitted by gendef.pl.
Yours,
Laurenz Albe
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2016-10-12 13:59:31 | Re: ICU integration |
Previous Message | Tom Lane | 2016-10-12 13:34:21 | Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1 |