From: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
---|---|
To: | "Dean Rasheed *EXTERN*" <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Kudos for Reviewers -- straw poll |
Date: | 2013-06-26 08:43:15 |
Message-ID: | A737B7A37273E048B164557ADEF4A58B17BB6C7F@ntex2010a.host.magwien.gv.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dean Rasheed wrote:
>> How should reviewers get credited in the release notes?
>>
>> a) not at all
>> b) in a single block titled "Reviewers for this version" at the bottom.
>> c) on the patch they reviewed, for each patch
>>
>
> b) Unless they contribute enough to the patch to be considered a co-author.
>
>
>> Should there be a criteria for a "creditable" review?
>>
>> a) no, all reviews are worthwhile
>> b) yes, they have to do more than "it compiles"
>> c) yes, only code reviews should count
>>
>
> a) Sometimes even "it compiles" can be worthwhile, if there is doubt
> over platform compatibility. All contributions should be acknowledged
> and encouraged.
>
>
>> Should reviewers for 9.4 get a "prize", such as a t-shirt, as a
>> promotion to increase the number of non-submitter reviewers?
>>
>> a) yes
>> b) no
>> c) yes, but submitters and committers should get it too
>>
>
> b) Getting your name in the fine manual is reward enough ;-)
+1, except that I like Josh's idea about a free ticket to pgCon.
Yours,
Laurenz Albe
From | Date | Subject | |
---|---|---|---|
Next Message | Atri Sharma | 2013-06-26 08:43:51 | Re: Bloom Filter lookup for hash joins |
Previous Message | Pavel Stehule | 2013-06-26 08:39:24 | Re: Bloom Filter lookup for hash joins |