Review: Display number of changed rows since last analyze

From: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Review: Display number of changed rows since last analyze
Date: 2013-06-17 11:49:02
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

This is a review of the patch in 5192D7D2(dot)8020605(at)catalyst(dot)net(dot)nz

The patch applies cleanly (with the exception of catversion.h of course),
compiles without warnings and passes the regression tests.

It contains enough documentation, though I'd prefer
"Estimated number of rows modified since the table was last analyzed"
"Estimated number of row changes (inserts + updates + deletes) since the last analyze"

The patch works as it should, and I think that this is a
useful addition. It only exposes a value that is already
available internally, so there shouldn't be any penalties.

I think that the column name is ok as it is, even if it
is a bit long - I cannot come up with a more succinct
idea. Perhaps "n_changed_since_analyze" could be shortened
to "n_mod_since_analyze", but that's not much of an improvement.

This is a very simple change, and I'll mark this patch "ready for committer".

Laurenz Albe


Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2013-06-17 11:53:30 Re: MD5 aggregate
Previous Message Simon Riggs 2013-06-17 11:48:52 Re: Patch for fail-back without fresh backup