| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Andrew Bille <andrewbille(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Windows locales and tests portability |
| Date: | 2026-09-22 07:40:24 |
| Message-ID: | A733EF40-6E1A-4670-BF83-5E729434340C@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Andrew,
On Sep 22, 2026, Andrew Bille wrote:
> fixing it in frontend locale
> initialization is preferable to teaching individual tests about
> Windows decimal separators.
My patch was intended to adapt the tests to the existing Windows
behavior. Yours changes that behavior for frontend users, which seems
worth discussing separately. A non-empty LC_NUMERIC may already be
inherited by scripts that currently work because Windows ignores it.
There is also the precedence question: this patch applies LC_NUMERIC
without checking LC_ALL, so it does not quite reproduce POSIX behavior.
I'd propose to fix the tests independently while discussing what locale
environment handling we want on Windows.
Thank you!
Best regards, Andrew Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Bille | 2026-09-22 07:45:26 | Re: Windows locales and tests portability |
| Previous Message | Andrew Bille | 2026-09-22 07:21:25 | Re: Windows locales and tests portability |