Memory allocation abstraction in pgcrypto

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Memory allocation abstraction in pgcrypto
Date: 2020-09-18 20:00:04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

pgcrypto has an abstraction for palloc/pfree via PX_OWN_ALLOC with the
intention to make it easy to swap out for another allocator. There are however
a number of palloc calls that have snuck in over the years, so the abstraction
is leaking a fair bit making it less useful. Since there have been no
complaints that I can see (searching the archives for PX_OWN_ALLOC yields zero
threads, and px_alloc none about this topic) then maybe it's time to remove it
and simplify the code?

The attached removes it in favor of using palloc() directly. Is there
any reason to keep it around still?

cheers ./daniel

Attachment Content-Type Size
0001-Remove-memory-allocation-abstraction-in-pgcrypto.patch application/octet-stream 22.8 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2020-09-18 20:17:37 Re: XversionUpgrade tests broken by postfix operator removal
Previous Message Mark Dilger 2020-09-18 19:41:54 Re: speed up unicode normalization quick check