| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. |
| Date: | 2021-03-01 20:20:31 |
| Message-ID: | A53C0A03-93B7-43DB-8409-9C43A2AA9321@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 1, 2021, at 12:05 PM, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
>
> The regression test you provided is not portable. I am getting lots of errors due to differing output of the form "page lsn=0/4DAD7E0". You might turn this into a TAP test and use a regular expression to check the output.
> May I ask you to ensure you used v3 of a patch to check? I've made tests portable in v3, probably, you've checked not the last version.
Yes, my review was of v2. Updating to v3, I see that the test passes on my laptop. It still looks brittle to have all the tid values in the test output, but it does pass.
> Thanks for your attention to the patch
Thanks for the patch!
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-01 20:22:08 | Re: Regex back-reference semantics and performance |
| Previous Message | Alvaro Herrera | 2021-03-01 20:09:29 | Re: [PATCH] Bug fix in initdb output |