Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row
Date: 2026-09-23 11:22:48
Message-ID: A53779F4-748C-42C1-B968-8B3B321B95E4@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Zsolt,

The snapshot change looks correct to me.

Two small points about the test:

The return value of poll_query_until() should be checked. On timeout it
returns false, so currently the test can continue without confirming
that the old worker has stopped.

ALTER DATABASE ... RESET does not change an existing worker's setting.
A worker starting between TRUNCATE and RESET can retain SERIALIZABLE
for the next test. I'd disable the subscription and wait for the worker
to stop, then truncate, reset the setting, and re-enable it.

Thank you!

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2026-09-23 11:32:43 Re: Add counted_by attribute
Previous Message Ashutosh Sharma 2026-09-23 11:18:25 Re: Orphaned Files in PostgreSQL