Re: pg_receivewal and SIGTERM

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Christoph Berg <myon(at)debian(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_receivewal and SIGTERM
Date: 2022-08-25 09:19:05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 23 Aug 2022, at 02:15, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Aug 22, 2022 at 04:05:16PM +0200, Christoph Berg wrote:
>> Do you mean it can, or can not be backpatched? (I'd argue for
>> backpatching since the behaviour is slightly broken at the moment.)
> I mean that it is fine to backpatch that, in my opinion.

I think this can be argued both for and against backpatching. Catching SIGTERM
makes a lot of sense, especially given systemd's behavior. On the other hand,
This adds functionality to something arguably working as intended, regardless
of what one thinks about the intent.

The attached adds the Exit Status section to pg_recvlogical docs which is
present in pg_receivewal to make them more aligned, and tweaks comments to
pgindent standards. This is the version I think is ready to commit.

Daniel Gustafsson

Attachment Content-Type Size
v2-0001-Handle-SIGTERM-in-pg_receivewal-and-pg_recvlogica.patch application/octet-stream 5.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2022-08-25 09:38:39 Re: Column Filtering in Logical Replication
Previous Message Önder Kalacı 2022-08-25 09:09:15 Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher