| From: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Call lazy_check_wraparound_failsafe earlier for parallel vacuum |
| Date: | 2022-12-23 00:05:11 |
| Message-ID: | A3F39AA3-A509-4EEF-BEFC-467DB3BA1246@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I adjusted the FAILSAFE_EVERY_PAGES comments, which now point out that
> FAILSAFE_EVERY_PAGES is a power-of-two. The implication is that the
> compiler is all but guaranteed to be able to reduce the modulo
> division into a shift in the lazy_scan_heap loop, at the point of the
> failsafe check. I doubt that it would really matter if the compiler
> had to generate a DIV instruction, but it seems like a good idea to
> avoid it on general principle, at least in performance sensitive code.
Thank you!
Regards,
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-12-23 01:06:40 | Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures |
| Previous Message | David Rowley | 2022-12-22 23:47:24 | Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options |