Re: citext operator precedence fix

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: citext operator precedence fix
Date: 2011-09-22 17:51:59
Message-ID: A3D2C0B7-6DDA-4933-8FBB-DDA72BD6AD2F@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sep 22, 2011, at 10:50 AM, Josh Berkus wrote:

>> Just write some comparisons like upthread, and see if the output is f or t. Put them into sql/citext.sql.
>
> Oh, ok. I thought you meant checking the actual function call.
>
> Tests go in the main SQL file? Shouldn't they have their own file?

That is the test file. The main SQL file is citext--1.0.sql. You'll actually need to bump the version number to 1.1, rename that file to citext--1.1.sql, and also add them to a citext--1.0--1.1.sql. There probably also needs to be a citext--unpackaged--1.1.sql file.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-09-22 18:07:28 Re: citext operator precedence fix
Previous Message Josh Berkus 2011-09-22 17:50:01 Re: citext operator precedence fix