| From: | Kevin Wooten <kdubb(at)me(dot)com> |
|---|---|
| To: | danap <danap(at)itstriangle(dot)com> |
| Cc: | PostgreSQL JDBC <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: PgJDBC: code reformat |
| Date: | 2015-12-27 18:00:01 |
| Message-ID: | A3A35314-9084-4C29-B68A-5A7C89BCA6F0@me.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
>
> 2. ONCE a complete format at once takes place, forget trying to decipher the
> mess that will be created, on diffs. Seems like a good way to inject
> undesired code. Bad idea.
>
I should stop with my opinions here… that being said…
One large nasty, “Reformatted code and added checkstyle”, may be to swallow. The alternative would be numerous small changes along with whole file reformats, e.g. “Fixed bug in generated SQL & formatted file to follow conventions”.
While large, the “whole reformat” method would be understandable. Good luck finding the “bug fix” in a whole file reformat.
> danap.
>
>
>
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Sitnikov | 2015-12-27 18:16:26 | Re: PgJDBC: code reformat |
| Previous Message | Vladimir Sitnikov | 2015-12-27 17:52:39 | Re: PgJDBC: code reformat |