Re: [PATCH] pageinspect: validate line pointers before using them

From: Greg Burd <greg(at)burd(dot)me>
To: pgsql-hackers(at)postgresql(dot)org
Cc: zhong950419(at)gmail(dot)com, gregburd(at)protonmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pageinspect: validate line pointers before using them
Date: 2026-10-22 13:51:59
Message-ID: A31D6973-4EB6-4973-ADF1-0B367DC0EC8E@burd.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 20 Oct 2026 20:35:16 -0400, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> Hi Greg,
>
> Thanks for testing this. I reproduced your TRAP on a cassert build with
> both patches applied.

Hey Shihao, nice work.

> v3 folds your change into 0001, with a Co-authored-by line for you.

Excellent, thanks!

> I also added a btree regression test that sets LP_DEAD on the high key of
> a multi-page index. It crashes without 0003 and gives the new error with it.
>
> Thanks,
> Shihao

best.

-greg

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-10-22 13:55:08 Re: [PATCH] Remove unused PageIsPredicateLocked()
Previous Message Dean Rasheed 2026-10-22 13:39:25 Re: [DEPARSE] EXPLAIN prints another ModifyTable's RETURNING aliases in a SubPlan