| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, VASUKI M <vasukianand0119(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, myon(at)debian(dot)org |
| Subject: | Re: Custom oauth validator options |
| Date: | 2026-11-03 21:37:34 |
| Message-ID: | A2FA12E8-78D0-431D-987A-162C77889F79@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 10 Oct 2026, at 12:12, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> I think this matters a bit more than for the builtin options, because
> unknown validator.* names can't be detected at reload time, and the
> view is the only place where an admin can see what the server actually
> parsed. The values still won't go through validations, e.g. in the
> above example typo will be simply displayed, but I think that's
> already better than hiding them and is worth doing.
Agreed, I think this is quite important and we should get that done before 19
ships. I'll get to reviewing this tomorrow.
> The attached patch emits them as validator.<name>=<value>, in the
> order they appear on the line. Since there's no limit on how many
> options a line can have, the fixed MAX_HBA_OPTIONS array doesn't work
> anymore, so options are sized dynamically now (MAX_HBA_OPTIONS plus
> the number of validator options).
I'm not crazy about this part though, I wonder if we should to put a hard cap
with a ... or something? I'll see what I can come up with.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2026-11-03 21:48:23 | Re: nbtree: opt-in leaf key prefix compression |
| Previous Message | Greg Burd | 2026-11-03 21:36:04 | Re: nbtree: opt-in leaf key prefix compression |