| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove redundant assignment in CreateWorkExprContext |
| Date: | 2026-01-14 08:22:49 |
| Message-ID: | A2B017FC-7E8D-4EAD-901A-DED4F21A65C9@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jan 14, 2026, at 15:13, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>
> On 8/21/25 5:47 AM, Chao Li wrote:
>> While discussing [1], I was reading execUtils.c, then I noticed this redundant local variable assignment in CreateWorkExprContext(). The attached patch fixed that.
> Nice spotted but I think your patch reduces readability. How about this?
>
> Andreas
> <v2-0001-Remove-redundant-assignemnt-in-CreateWorkExprCont.patch>
Hi Andraes,
Thank you very much for reviewing and bumping this patch. I’m fine with your tuning; I don’t have a strong preference, so I’m happy to leave the final decision to the committers.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Tselebrovskiy | 2026-01-14 08:32:34 | Re: 001_password.pl fails with --without-readline |
| Previous Message | Michael Paquier | 2026-01-14 08:08:08 | Re: Use correct macro for accessing offset numbers. |