| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Mark ItemPointer parameters as const in tuple/table lock functions |
| Date: | 2025-08-28 02:27:58 |
| Message-ID: | A170F2E3-E3EA-47C7-A373-9B32D4D589DC@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Aug 27, 2025, at 17:24, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> This style of having Foo be a type alias for pointer-to-FooData is an ancient Postgres coding convention that does not map well to modern C that has an emphasis on judicious use of qualifiers and attributes, and so if this abstraction gets in the way, we sometimes crack it open, like in the case of ItemPointerGetBlockNumber() etc.
You are right, we want to protect the stuff that “tid” points to instead of “tid” itself:
*tid = something; // should hit compile error
tid = something; // ok
Also, thanks for telling the history. I have updated the patch to use “const ItemPointerData *” in the same way as ItemPointerGetBlockNumber().
Attached is the v2 patch.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-08-28 02:30:13 | Re: Mark ItemPointer parameters as const in tuple/table lock functions |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-08-28 02:23:56 | Avoid retaining conflict-related data when no tables are subscribed |