Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags

From: "Seki, Eiji" <seki(dot)eiji(at)jp(dot)fujitsu(dot)com>
To: 'Haribabu Kommi' <kommi(dot)haribabu(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags
Date: 2017-03-22 02:53:51
Message-ID: A11BD0E1A40FAC479D740CEFA373E203396B39B0@g01jpexmbkw05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2017-03-21 07:46:47 Haribabu Kommi wrote:
>On Tue, Mar 21, 2017 at 3:16 PM, Seki, Eiji <seki(dot)eiji(at)jp(dot)fujitsu(dot)com> wrote:
>+/* Use these flags in GetOldestXmin as "flags" */
>How about some thing like the following.
>/* Use the following flags as an input "flags" to GetOldestXmin function */
>+/* Ignore vacuum backends (Note: this also ignores analyze with vacuum backends) */
>+/* Ignore analyze backends (Note: this also ignores vacuum with analyze backends) */
>Whenever the above flags are passed to the GetOldestXmin() function,
>it just verifies whether any one of the flags are set in the backend flags
>or not. And also actually the PROC_IN_ANALYZE flag will set when
>analyze operation is started and reset at the end. I feel, it is not
>required to mention the Note section.
>+/* Ignore vacuum backends and analyze ones */
>How about changing it as "Ignore both vacuum and analyze backends".

Thank you for your review, again.

I think your proposals are better, so I reflected them.

Eiji Seki

Attachment Content-Type Size
get_oldest_xmin_with_ignore_flags_v4.patch application/octet-stream 8.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-03-22 03:02:37 Re: [HACKERS] Questionable tag usage
Previous Message Craig Ringer 2017-03-22 02:51:45 Re: Logical decoding on standby