Re: multi-install PostgresNode fails with older postgres versions

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: multi-install PostgresNode fails with older postgres versions
Date: 2021-04-19 18:17:11
Message-ID: A02EECD9-098B-4CCB-B3F9-7F58BECF8EF5@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Apr 19, 2021, at 10:50 AM, Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> wrote:
>
>> The community needs a single shared PostgresNode implementation that can be
>> used by scripts which reproduce bugs.
>
> Which means it could be OK to have a PostgresNode implementation, leaving in
> core source-tree, which supports broader needs than the core ones (older
> versions and some more methods)? Did I understood correctly?

Yes, I believe it should be in core.

I don't know about "some more methods", as it depends which methods you are proposing.

> If this is correct, I suppose this effort could be committed early in v15 cycle?

I don't care to speculate on that yet.

> Does it deserve some effort to build some dedicated TAP tests for these
> modules? I already have a small patch for this waiting on my disk for some more
> tests and review...

I did that, too, in the 0002 version of my patch. Perhaps we need to merge your work and mine.


Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-04-19 18:49:05 Re: Bogus collation version recording in recordMultipleDependencies
Previous Message Peter Eisentraut 2021-04-19 18:16:55 Re: Windows default locale vs initdb