From: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com> |
---|---|
To: | 'Magnus Hagander' <mha(at)sollentuna(dot)net>, pgsql-patches(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org |
Subject: | Re: win32 setitimer implementation |
Date: | 2004-02-17 11:24:40 |
Message-ID: | A02DEC4D1073D611BAE8525405FCCE2B55F2FD@harris.memetrics.local |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers-win32 pgsql-patches |
> Here is a patch that implements setitimer() on win32. With this patch
> applied, deadlock detection and statement_timeout now works.
>
> The file timer.c goes into src/backend/port/win32/.
Minor comments:
* "timer.c" has shmem.c in header
* I'd suggest Asserts on the remaining 2 limitations ("zero" it_interval and
NULL ovalue), on the off chance that some future change to the source
expects them (ie. so we'll find out about it under win32 pretty quickly);
possibly provide defines of ITIMER_VIRT and ITIMER_PROF, for completeness.
Looks good,
Claudio
---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2004-02-17 14:34:40 | Re: win32 setitimer implementation |
Previous Message | Bruce Momjian | 2004-02-17 03:47:44 | Re: Updated win32 readdir patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2004-02-17 21:03:35 | Re: win32 setitimer implementation |
Previous Message | Neil Conway | 2004-02-17 09:08:33 | Re: Repost: Linking references in documentation |