Re: New win32 signals patch (3)

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, 'Magnus Hagander' <mha(at)sollentuna(dot)net>, 'pgsql-hackers-win32 ' <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: New win32 signals patch (3)
Date: 2004-02-04 11:01:26
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F2D0@harris.memetrics.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32


[pushing our IM discussion to the list]

Magnus, the SIGCHLD implementation snippet I sent over to you works
perfectly (possible thread unsafe issues in logging aside), but it looks
like I messed up the (obviously untested) win32_waitpid code after all.

You'll need to go to win32_RemoveChild, and change the lines:

win32_childPIDArray[win32_numChildren] =
win32_childPIDArray[i];
win32_childHNDArray[win32_numChildren] =
win32_childHNDArray[i];
to:
win32_childPIDArray[i] =
win32_childPIDArray[win32_numChildren];
win32_childHNDArray[i] =
win32_childHNDArray[win32_numChildren];

(Pretty obvious now that we can actually run this code. Yay! :-)

Will I leave you to format up a new patch and include this change + the
SIGCHLD code?

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Merlin Moncure 2004-02-04 14:35:00 Re: interix port running...
Previous Message Claudio Natoli 2004-02-04 09:55:28 Re: New win32 signals patch (3)