From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org |
Subject: | Re: Support json_errdetail in FRONTEND builds |
Date: | 2024-03-15 23:59:19 |
Message-ID: | A0058249-0993-4903-A130-0115039342A5@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Mar 16, 2024, at 8:53 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>
>>
>> On 15 Mar 2024, at 21:56, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> On Fri, Mar 15, 2024 at 10:15 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>> Daniel Gustafsson <daniel(at)yesql(dot)se <mailto:daniel(at)yesql(dot)se>> writes:
>>> I can't see how refusing to free memory owned and controlled by someone else,
>>> and throwing an error if attempted, wouldn't be a sound defensive programming
>>> measure.
>>
>> I think the argument is about what "refusal" looks like.
>> An Assert seems OK to me, but anything based on elog is
>> likely to be problematic, because it'll involve exit()
>> somewhere.
>>
>> Yeah, I agree an Assert seems safest here.
>>
>> I'd like to get this done ASAP so I can rebase my incremental parse patchset. Daniel, do you want to commit it? If not, I can.
>
> Sure, I can commit these patches. It won't be until tomorrow though since I
> prefer to have ample time to monitor the buildfarm, if you are in a bigger rush
> than that then feel free to go ahead.
>
tomorrow will be fine, thanks
Cheers
Andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2024-03-16 00:12:02 | Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan |
Previous Message | Thomas Munro | 2024-03-15 23:52:59 | Re: Streaming I/O, vectored I/O (WIP) |