| From: | Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
|---|---|
| To: | Andrei Zubkov <zubkov(at)moonset(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |
| Date: | 2023-10-25 06:59:09 |
| Message-ID: | 9fa9c155-b32c-4a3b-80c1-2b69b23909b8@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/10/2023 19:40, Andrei Zubkov wrote:
> Hi hackers,
>
> New version 23 attached. It contains rebase to the current master.
I discovered the patch and parameters you've proposed. In my opinion,
the stats_since parameter adds valuable information and should
definitely be included in the stats data because the statement can be
noteless removed from the list and inserted again.
But minmax_stats_since and changes in the UI of the reset routine look
like syntactic sugar here.
I can't convince myself that it is really needed. Do you have some set
of cases that can enforce the changes proposed? Maybe we should
intensively work on adding the 'stats_since' parameter and continue the
discussion of the necessity of another one?
--
regards,
Andrei Lepikhov
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-10-25 07:23:28 | Re: Simplify create_merge_append_path a bit for clarity |
| Previous Message | Richard Guo | 2023-10-25 06:45:59 | Re: A performance issue with Memoize |