| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix segfault during EvalPlanQual with mix of local and foreign p |
| Date: | 2021-09-07 09:35:03 |
| Message-ID: | 9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 06/09/2021 11:50, Amit Langote wrote:
> Quite late but to I was looking at this and noticed this comment:
>
> + /*
> + * Direct modifications cannot be re-evaluated by EvalPlanQual, so
> + * don't bother preparing the FDW. There can ForeignScan nodes in the
> + * EvalPlanQual subtree, but ExecForeignScan should never be called.
> + */
>
> The 2nd sentence seems to be missing a "be" between "can" and
> "ForeignScan". Also, does it mean the following?
>
> "There can be ForeignScan nodes in the EvalPlanQual plan subtree, but
> ExecForeignScan should never be called on them [during EvalPlanQual]."
>
> I've attached a patch that changes the text like that.
Applied, thanks!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-07 14:52:30 | pgsql: Finish reverting 3eda9fc09fd6b9a1aec2d0113c633c69c3214b4d. |
| Previous Message | Heikki Linnakangas | 2021-09-07 08:56:52 | pgsql: Fix missing words in comment. |