Re: WIP: Covering + unique indexes.

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: WIP: Covering + unique indexes.
Date: 2018-03-28 15:25:32
Message-ID: 9f51082e06167bdb926dd49fbcc34c4c@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-03-28 16:59, Anastasia Lubennikova wrote:
> Here is the new version of the patch set.

I can't get these to apply:

patch -b -l -F 25 -p 1 <
/home/aardvark/download/pgpatches/0110/covering_indexes/20180328/0001-Covering-core-v8.patch

1 out of 19 hunks FAILED -- saving rejects to file
src/backend/utils/cache/relcache.c.rej

$ cat src/backend/utils/cache/relcache.c.rej
--- src/backend/utils/cache/relcache.c
+++ src/backend/utils/cache/relcache.c
@@ -542,7 +542,7 @@
attp = (Form_pg_attribute)
GETSTRUCT(pg_attribute_tuple);

if (attp->attnum <= 0 ||
- attp->attnum > relation->rd_rel->relnatts)
+ attp->attnum >
RelationGetNumberOfAttributes(relation))
elog(ERROR, "invalid attribute number %d for
%s",
attp->attnum,
RelationGetRelationName(relation));

Erik Rijkers

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikhil Sontakke 2018-03-28 15:28:33 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Tomas Vondra 2018-03-28 15:17:04 Re: [HACKERS] [PATCH] Incremental sort