Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

On 17/06/2019 05:58, Magnus Hagander wrote:
> On Sun, Jun 16, 2019 at 7:43 PM Stephen Frost <sfrost(at)snowman(dot)net
> <mailto:sfrost(at)snowman(dot)net>> wrote:
>
>
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>) wrote:
> > Stephen Frost <sfrost(at)snowman(dot)net <mailto:sfrost(at)snowman(dot)net>>
> writes:
>
> > > what we should do is clean them up (and possibly
> > > throw a WARNING or similar at the user saying "something
> modified your
> > > postgresql.auto.conf in an unexpected way").  I'd suggest we
> do that on
> > > every ALTER SYSTEM call.
> >
> > +1 for having ALTER SYSTEM clean out duplicates.  Not sure whether
> > a WARNING would seem too in-your-face.
>
> I'd hope for a warning from basically every part of the system when it
> detects, clearly, that a file was changed in a way that it shouldn't
> have been.  If we don't throw a warning, then we're implying that it's
> acceptable, but then cleaning up the duplicates, which seems pretty
> confusing.
>
>
> +1. Silently "fixing" the file by cleaning up duplicates is going to
> be even more confusing to uses who had seen them be there before.
>
> --
>  Magnus Hagander
>  Me: https://www.hagander.net/ <http://www.hagander.net/>
>  Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

I thinking fixing this silently should be at least a hanging offence.

At one time I came a cross a language PL/1, that would silently
'correct' some mistakes, without indicating what it did.  I thought this
was extremely dangerous, that could lead to some very nasty and
unexpected bugs!

It is most important that people be aware of possibly conflicting
changes, or that values they saw in postgresql.conf may have been changed.

Hmm... this suggests that all the implied defaults should be explicitly
set!  Would that be too greater change to make?

Cheers,
Gavin