Re: POC: make mxidoff 64 bits

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Maxim Orlov <orlovmg(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Subject: Re: POC: make mxidoff 64 bits
Date: 2025-11-25 10:07:27
Message-ID: 9ee6324a-44fc-42fb-bf8e-7c3b53395588@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Looking at the upgrade code, in light of the "IPC/MultixactCreation on
the Standby server" thread [1], I think we need to make it more
tolerant. It's possible that there are 0 offsets in
pg_multixact/offsets. That might or might not be a problem: it's OK as
long as those multixids don't appear in any heap table, or you might
actually have lost those multixids, which is bad but the damage has
already been done and upgrade should not get stuck on it.
GetOldMultiXactIdSingleMember() currently asserts that the offset is
never zero, but it should try to do something sensible in that case
instead of just failing.

[1]
https://www.postgresql.org/message-id/172e5723-d65f-4eec-b512-14beacb326ce%40yandex.ru

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2025-11-25 10:15:58 Re: [PATCH] Avoid pallocs in async.c's SignalBackends critical section
Previous Message Nazir Bilal Yavuz 2025-11-25 10:07:24 Re: BUG #19095: Test if function exit() is used fail when linked static