| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | use of SEQ_MINVALUE in btree_gin |
| Date: | 2016-07-12 01:34:00 |
| Message-ID: | 9ec6dce7-fbdd-98d7-85f8-0c18183b82c9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
btree_gin uses SEQ_MINVALUE as a way to get the smallest int64 value.
This is actually wrong because the smallest int64 value is
SEQ_MINVALUE-1, so this might be slightly broken.
The whole thing was done as a convenience when INT64_IS_BUSTED had to be
considered, but I think we can get rid of that now. See attached
proposed patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| btree-gin-seq-minvalue.patch | text/plain | 831 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2016-07-12 02:04:17 | Re: asynchronous and vectorized execution |
| Previous Message | Craig Ringer | 2016-07-12 01:32:18 | Re: remove checkpoint_warning |