| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Mark Wong <markwkm(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: updates for handling optional argument in system functions |
| Date: | 2026-04-07 23:28:29 |
| Message-ID: | 9e3ad0f4-c4ef-436b-a5a1-28f600d76a61@proxel.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/8/26 12:26 AM, Andreas Karlsson wrote:
> On 4/2/26 8:36 PM, Mark Wong wrote:
>> I've attached v5, simply a needed rebase due to some other churn in
>> pg_proc.dat.
>
> Nice, I like the patch. The code changes looks good and I like the
> removal of these duplicate functions and use of default arguments. But I
> think the names of the arguments should be aligned with the names we
> have in the documentation. And that may mean that we should change the
> documentation.
Forgot to attach rebased patches.
--
Andreas Karlsson
Percona
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Handle-pg_get_ruledef-default-args-in-system_func.patch | text/x-patch | 2.5 KB |
| v6-0002-Handle-pg_get_viewdef-default-args-in-system_func.patch | text/x-patch | 3.9 KB |
| v6-0003-Handle-pg_get_indexdef-default-args-in-system_fun.patch | text/x-patch | 2.6 KB |
| v6-0004-Handle-pg_get_constraintdef-default-args-in-syste.patch | text/x-patch | 2.6 KB |
| v6-0005-Handle-pg_get_expr-default-args-in-system_functio.patch | text/x-patch | 3.3 KB |
| v6-0006-Handle-pg_get_triggerdef-default-args-in-system_f.patch | text/x-patch | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-04-07 23:30:36 | Re: Adding locks statistics |
| Previous Message | Alexander Korotkov | 2026-04-07 23:23:29 | Re: Implement waiting for wal lsn replay: reloaded |