Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

From: Gilles Darold <gilles(at)migops(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Proposal for HIDDEN/INVISIBLE column
Date: 2021-10-18 20:15:23
Message-ID: 9d5205f4-1dfc-07c6-76a1-580b385debd0@migops.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le 18/10/2021 à 18:54, Alvaro Herrera a écrit :
> I suggest to look for output test files that are being massively
> modified by this patch. I think those are likely unintended:
>
>> diff --git a/src/test/regress/expected/collate.icu.utf8.out b/src/test/regress/expected/collate.icu.utf8.out
>> diff --git a/src/test/regress/expected/collate.linux.utf8.out b/src/test/regress/expected/collate.linux.utf8.out
>> diff --git a/src/test/regress/expected/compression.out b/src/test/regress/expected/compression.out
>> diff --git a/src/test/regress/expected/xml.out b/src/test/regress/expected/xml.out
>> diff --git a/src/test/regress/expected/xmlmap.out b/src/test/regress/expected/xmlmap.out

My bad, thanks for the report Alvaro. New patch version v3 should fix that.

--
Gilles Darold

Attachment Content-Type Size
0001-hidden-column-v3.patch text/x-patch 1.6 MB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-10-18 20:36:34 Re: [PATCH] Proposal for HIDDEN/INVISIBLE column
Previous Message Anton A. Melnikov 2021-10-18 19:11:12 Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements