Re: INCLUDING COMPRESSION

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: INCLUDING COMPRESSION
Date: 2021-04-15 14:24:07
Message-ID: 9d2e08ce-8ae1-7d7b-b6c2-c8e608254342@oss.nttdata.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On 2021/04/15 11:54, Michael Paquier wrote:
> On Wed, Apr 14, 2021 at 11:46:58PM +0900, Fujii Masao wrote:
>> The syntax for like_option in CREATE TABLE docs seems to forget to mention
>> INCLUDING COMPRESSION option. I think the following fix is necessary.
>> Patch attached.
>>
>> -{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
>> +{ INCLUDING | EXCLUDING } { COMMENTS | COMPRESSION | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
>
> Indeed.

Thanks! Pushed.

> May I ask at the same time why gram.y (TableLikeOption) and
> parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
> option in alphabetical order with the rest? Ordering them makes
> easier a review of them.

I'm not sure why. But +1 to make them in alphabetical order.
Patch attached.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
including_compression_order.patch text/plain 1.8 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2021-04-15 20:04:24 Typo in DATATYPE-JSONPATH
Previous Message Michael Paquier 2021-04-15 08:02:32 Re: Typo in psql doc

Browse pgsql-hackers by date

  From Date Subject
Next Message Rushabh Lathia 2021-04-15 14:29:01 Re: Commit ab596105b55 - BRIN minmax-multi indexes
Previous Message Tom Lane 2021-04-15 14:19:03 Re: Commit ab596105b55 - BRIN minmax-multi indexes