Re: PoC: Simplify recovery after dropping a table by LOGGING the restore LSN

Hi Salma

On 12/10/2026 14:14, Salma El-Sayed wrote:
> Attached is v8 rebased on master.

Thanks for the update.

I played a bit with v8 and it seems that the lsn is logged a bit too
early. If a drop database command fails, it still gets logged:

psql (20devel)
Type "help" for help.

postgres=# create table t (g int, pad text);
CREATE TABLE
postgres=# insert into t select g, repeat('x', 100) from
generate_series(1, 600000) g;
INSERT 0 600000
postgres=# create database db;
CREATE DATABASE
postgres=# update t set g = g + 1;
UPDATE 600000
postgres=# set log_object_drops to on;
SET
postgres=# set statement_timeout = '20ms';
SET
postgres=# drop database db;
ERROR: canceling statement due to statement timeout

postgres=# select oid,datname from pg_database where datname = 'db';
oid | datname
-------+---------
16414 | db
(1 row)

.. but the logs show:

LOG: database "db" (OID 16414) dropped, lsn=0/47AAC7E0

Just for testing, I placed the ereport after remove_dbtablespaces() and
the lsn is no longer logged in the scenario above -- see 0002, but it
needs more testing. WDYT?

I will take a closer look at the tests in the next few days.

Best, Jim