Re: [PATCH] Add pretty-printed XML output option

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add pretty-printed XML output option
Date: 2023-02-16 07:08:16
Message-ID: 9c58fb29-05c9-3c34-8521-d807e53a53e1@uni-muenster.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 16.02.23 05:38, Nikolay Samokhvalov wrote:
> On Thu, Feb 9, 2023 at 2:31 AM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> I suggest we call it "xmlformat", which is an established term for
> this.
>
>
> Some very-very old, rusted memory told me that there was something in
> standard – and indeed, it seems it described an optional Feature X069,
> “XMLSerialize: INDENT” for XMLSERIALIZE. So probably pretty-printing
> should go there, to XMLSERIALIZE, to follow the standard?
>
> Oracle also has an option for it in XMLSERIALIZE, although in a
> slightly different form, with ability to specify the number of spaces
> for indentation
> https://docs.oracle.com/database/121/SQLRF/functions268.htm#SQLRF06231.

Hi Nikolay,

My first thought was to call it xmlpretty, to make it consistent with
the jsonb equivalent "jsonb_pretty". But yes, you make a good
observation .. xmlserialize seems to be a much better candidate.

I would be willing to refactor my patch if we agree on xmlserialize.

Thanks for the suggestion!

Jim

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2023-02-16 07:08:37 Re: Missing free_var() at end of accum_sum_final()?
Previous Message Robert Haas 2023-02-16 07:07:57 Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy