| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove Item type |
| Date: | 2025-10-27 09:21:48 |
| Message-ID: | 9c32376b-4c6c-4410-ac28-840480b0a29b@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.10.25 17:32, Nathan Bossart wrote:
> On Mon, Sep 29, 2025 at 12:20:00PM +0200, Peter Eisentraut wrote:
>> So I'm proposing to remove the Item type, replace it with void * in
>> function prototypes, and remove all the casts.
>
> The general idea seems reasonable to me, but I'm a little concerned that
> using "void *" could break extensions written in C++ (see commit d5ca15e).
> I haven't confirmed there's an actual issue here, though.
Thanks for checking. This is not a problem, because what C++ disallows
is implicit conversion from void * to another pointer type, but it does
allow it the other way around, which is what would be happening here.
I have committed this.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2025-10-27 09:22:13 | Re: Improve pg_sync_replication_slots() to wait for primary to advance |
| Previous Message | Fujii Masao | 2025-10-27 09:13:53 | Re: Suggestion to add --continue-client-on-abort option to pgbench |