Re: backend/nodes cleanup: Move loop variables definitions into for statement

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: backend/nodes cleanup: Move loop variables definitions into for statement
Date: 2025-11-25 14:46:39
Message-ID: 9bcbdbfe-50c4-4a49-8891-9ce229c35125@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25.11.25 04:46, Chao Li wrote:
>
> On Tue, Nov 25, 2025 at 7:38 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com
> <mailto:li(dot)evan(dot)chao(at)gmail(dot)com>> wrote:
>
>
> On Mon, Nov 24, 2025 at 11:00 PM Peter Eisentraut
> <peter(at)eisentraut(dot)org <mailto:peter(at)eisentraut(dot)org>> wrote:
>
> On 19.11.25 11:32, Chao Li wrote:
> > On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut
> <peter(at)eisentraut(dot)org <mailto:peter(at)eisentraut(dot)org>
> > <mailto:peter(at)eisentraut(dot)org <mailto:peter(at)eisentraut(dot)org>>>
> wrote:
> >
> >
> >
> >     In a couple of cases, you are changing the type of the
> loop variable
> >     from Size to int.  I would not expect such a change in a
> patch of this
> >     nature.  If you have a reason to change it, please
> explain it (but I
> >     doubt the change is correct).
> >
> >
> > That was a mistake. I fixed it in v3.
>
> Still not correct in outDatum().
>
>
> Oops! Fixed in v4.
>
>
> Rebased to v5.

committed

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-11-25 14:50:01 The pgperltidy diffs in HEAD
Previous Message Daniel Gustafsson 2025-11-25 14:39:22 Re: Serverside SNI support in libpq