| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Michel Pelletier <pelletier(dot)michel(at)gmail(dot)com> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Make EXPLAIN generate a generic plan for a parameterized query |
| Date: | 2023-01-09 16:40:01 |
| Message-ID: | 9b8512cf5ed3872a4962938e79141d33d501c8d6.camel@cybertec.at |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2022-12-27 at 14:37 -0800, Michel Pelletier wrote:
> I built and tested this patch for review and it works well, although I got the following warning when building:
>
> analyze.c: In function 'transformStmt':
> analyze.c:2919:35: warning: 'generic_plan' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 2919 | pstate->p_generic_explain = generic_plan;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
> analyze.c:2909:25: note: 'generic_plan' was declared here
> 2909 | bool generic_plan;
> | ^~~~~~~~~~~~
Thanks for checking. The variable should indeed be initialized, although
my compiler didn't complain.
Attached is a fixed version.
Yours,
Laurenz Albe
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-EXPLAIN-option-GENERIC_PLAN.v4.patch | text/x-patch | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2023-01-09 16:50:10 | Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE |
| Previous Message | Vik Fearing | 2023-01-09 16:23:04 | Re: MERGE ... RETURNING |