Re: headerscheck warnings with late-model gcc

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: headerscheck warnings with late-model gcc
Date: 2025-08-06 18:25:56
Message-ID: 9b7ef918-302e-4c84-bc04-a37f5c2b5f92@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.08.25 20:09, Tom Lane wrote:
> Curiously, no such complaints appear with cpluspluscheck (which is
> using g++ 15.1.1). I don't really understand why not: why would
> they have turned on -Wmissing-variable-declarations by default
> for C but not C++? But anyway, since there doesn't seem to be
> any C++ compatibility issue here, I think it's sufficient to fix
> this in master and not back-patch.

-Wmissing-variable-declarations is added by us as of PG18 (commit
66188912566). It's available since gcc 14 and doesn't exist for C++.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-08-06 18:38:38 Re: More protocol.h replacements this time into walsender.c
Previous Message Nathan Bossart 2025-08-06 18:14:12 Re: analyze-in-stages post upgrade questions