| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, mitsuru(dot)hinata(dot)5432(at)gmail(dot)com |
| Subject: | Re: Fix pg_stat_reset_single_table_counters function |
| Date: | 2023-08-21 04:32:24 |
| Message-ID: | 9b5dbfd294a7deabe1323b04fa29f9db@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-08-21 11:33, Kyotaro Horiguchi wrote:
> On 2023/08/15 14:13, Masahiro Ikeda wrote:
>> On 2023-08-15 11:48, Masahiko Sawada wrote:
>>> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
>>> -- insert or update in 'pg_shdescription'
>>>
>>> I think the current_database should be quoted (see other examples
>>> where using current_database(), e.g. collate.linux.utf8.sql). Also it
>>> would be better to reset the comment after the test.
>>
>
> I'm not sure about others, but I would avoid using the name
> "current_database" for the variable.
>
> I would just use "database" or "db" instead.
Thanks! I agree your comment.
I fixed in v5 patch.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Fix-pg_stat_reset_single_table_counters-function.patch | text/x-diff | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-08-21 04:34:26 | Re: Fix pg_stat_reset_single_table_counters function |
| Previous Message | Masahiro Ikeda | 2023-08-21 04:08:58 | Re: Make --help output fit within 80 columns per line |