| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, mitsuru(dot)hinata(dot)5432(at)gmail(dot)com |
| Subject: | Re: Fix pg_stat_reset_single_table_counters function |
| Date: | 2023-08-21 02:33:28 |
| Message-ID: | 0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Apologies. In the previous mail, I mistakenly addressed it to the wrong
recipients. Reposted.
On 2023/08/15 14:13, Masahiro Ikeda wrote:
> On 2023-08-15 11:48, Masahiko Sawada wrote:
>> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
>> -- insert or update in 'pg_shdescription'
>>
>> I think the current_database should be quoted (see other examples
>> where using current_database(), e.g. collate.linux.utf8.sql). Also it
>> would be better to reset the comment after the test.
>
> Thanks! I fixed the issues in the v4 patch.
I'm not sure about others, but I would avoid using the name
"current_database" for the variable.
I would just use "database" or "db" instead.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chapman Flack | 2023-08-21 03:19:47 | Re: Extract numeric filed in JSONB more effectively |
| Previous Message | Masahiro Ikeda | 2023-08-21 02:04:23 | Re: Rethink the wait event names for postgres_fdw, dblink and etc |