Re: [19] CREATE SUBSCRIPTION ... SERVER

On Mon, 2026-03-09 at 11:53 +0530, Amit Kapila wrote:
> > +# Replicate the changes without columns
> > +$node_publisher->safe_psql('postgres', "CREATE TABLE
> > tab_no_col()");
> > +$node_publisher->safe_psql('postgres',
> > + "INSERT INTO tab_no_col default VALUES");
> >
> > I don't see a subscriber-side table or verification code to verify
> > the
> > above test.
> >
>
> I see that the committed version (8185bb5347) has this part of the
> test, isn't that test incomplete, if not, tell me what am I missing?

In 8185bb5347, contrib/postgres_fdw/t/010_subscription.pl has:

...
# Setup structure on subscriber
$node_subscriber->safe_psql('postgres', "CREATE EXTENSION
postgres_fdw");
$node_subscriber->safe_psql('postgres', "CREATE TABLE tab_ins (a int,
b int)");
...
$result =
$node_subscriber->safe_psql('postgres', "SELECT count(*) FROM (SELECT
f.b = l.b as match FROM tab_ins l, f_tab_ins f WHERE l.a = f.a) WHERE
match");
is($result, qq(1050), 'check that inserted data was copied to
subscriber');
...

which creates the subscriber-side table and verifies the result. If I
change 1050 -> 1051, then the test fails, so I think it's functioning.

Perhaps I don't understand the question?

> It seems I have sent this message after you have committed the last
> version.

Yes, thank you, I will address those shortly.

Regards,
Jeff Davis