Re: pgsql: Improve error messages for incorrect types of logical replicatio

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Improve error messages for incorrect types of logical replicatio
Date: 2019-01-13 10:01:42
Message-ID: 9a9cf621389ddad0945295f7b4354984@xs4all.nl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-01-13 08:45, Michael Paquier wrote:
> Improve error messages for incorrect types of logical replication
> targets
>
> Discussion:
> https://postgr.es/m/41799bee-40eb-7bb5-80b1-325ce17518bc@lab.ntt.co.jp
>
> master
> https://git.postgresql.org/pg/commitdiff/373bda61d2d620e704815553978726c9be9e1209
>
> Modified Files
> --------------
> src/backend/executor/execReplication.c | 22 ++++++++++++++++++++--

Good idea, but now one message (for RELKIND_FOREIGN_TABLE) omits
'target'.

So I think
errmsg("cannot use relation \"%s.%s\" as logical replication"

should be:
errmsg("cannot use relation \"%s.%s\" as logical replication target"

Do you agree?

Thanks,

Erik Rijkers

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-01-13 13:42:43 pgsql: Fix error message for logical replication targets
Previous Message Peter Eisentraut 2019-01-13 09:52:53 pgsql: Make INSTALL makefile rule more robust