| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore |
| Date: | 2025-04-16 16:17:53 |
| Message-ID: | 9a1a342a-52fb-4be6-892a-8be387a51792@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2025-04-14 Mo 8:20 AM, Álvaro Herrera wrote:
> On 2025-Apr-04, Andrew Dunstan wrote:
>
>> Non text modes for pg_dumpall, correspondingly change pg_restore
> I think the new oid_string_list stuff in this commit is unnecessary, and
> we can remove a bunch of lines by simplifying that to using
> SimplePtrList, as the attached illustrates. (Perhaps the names of
> members of the proposed struct can be improved.)
>
> I also propose to remove the open-coded implementation of pg_get_line.
>
> WDYT?
>
> I'm also not sure about the double sscanf() business there ... There
> must be a better way to do this.
>
Pushed your patch plus cleanup of the sscanf stuff.
Thanks!
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-04-16 16:34:28 | Re: pgsql: Add support for basic NUMA awareness |
| Previous Message | Andrew Dunstan | 2025-04-16 16:15:42 | pgsql: pg_restore cleanups |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-04-16 16:18:01 | Re: Add Pipelining support in psql |
| Previous Message | Maciek Sakrejda | 2025-04-16 16:09:41 | Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment |