Re: PG version is not seen in pg_upgrade test log

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Potapov Alexander <a(dot)potapov(at)postgrespro(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: PG version is not seen in pg_upgrade test log
Date: 2025-12-02 10:22:36
Message-ID: 9F915959-7620-49A7-A63F-49FD87D57F64@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 30 Nov 2025, at 10:11, Potapov Alexander <a(dot)potapov(at)postgrespro(dot)com> wrote:

> I ran pg_upgrade tests (make check -C src/bin/pg_upgrade) and found that test log does not contain PG version:

> - $node->dump_info;
> -
> $node->_set_pg_version;
> + $node->dump_info;
> +

This seems like a correct change, reading the history around this code makes it
seem like it just happened to end up in the wrong place in one of many
refactorings.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chengpeng Yan 2025-12-02 10:22:51 Re: Add a greedy join search algorithm to handle large join problems
Previous Message Xuneng Zhou 2025-12-02 10:10:02 Re: Implement waiting for wal lsn replay: reloaded