Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?
Date: 2023-10-24 20:45:48
Message-ID: 9F3A2930-4E32-498E-9C9F-94676A10DC38@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Oct 2023, at 22:34, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> I went ahead and applied this on master, thanks for review! Now to see if
>> there will be any noticeable difference in resource usage.
>
> I think that tools like Coverity are likely to whine about your
> use of sprintf instead of snprintf. Sure, it's perfectly safe,
> but that won't stop the no-sprintf-ever crowd from complaining.

Fair point, that's probably quite likely to happen. I can apply an snprintf()
conversion change like this in the two places introduced by this:

- sprintf(s, "%d", port);
+ sprintf(s, sizeof(s), "%d", port);

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-10-24 21:09:54 Re: CRC32C Parallel Computation Optimization on ARM
Previous Message Bruce Momjian 2023-10-24 20:39:00 Re: Document aggregate functions better w.r.t. ORDER BY