| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2021-07-20 20:03:40 |
| Message-ID: | 9EFB22B8-28DC-4C44-866E-B45F5E526C34@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jul 20, 2021, at 11:57 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> I don't really understand what your problem is with how the patch set
> leaves pg_basebackup.
I don't have a problem with how the patch set leaves pg_basebackup.
> On the server side, because I dropped the
> bbarchiver stuff, basebackup.c still ends up knowing a bunch of stuff
> about tar. pg_basebackup.c, however, really doesn't know anything much
> about tar any more. It knows that if it's getting a tar file and needs
> to parse a tar file then it had better call the tar parsing code, but
> that seems difficult to avoid.
I was only imagining having a callback for injecting manifests or recovery configurations. It is not necessary that this be done in the current patch set, or perhaps ever.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Filip Gospodinov | 2021-07-20 20:04:02 | Re: Fix pkg-config file for static linking |
| Previous Message | Robert Haas | 2021-07-20 19:34:22 | Re: [PATCH] Automatic HASH and LIST partition creation |