| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Separators in pg_hosts.conf fields |
| Date: | 2026-04-26 21:40:13 |
| Message-ID: | 9E767D01-08A1-4DF1-8122-B11AD932C8BA@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 26 Apr 2026, at 23:32, Noah Misch <noah(at)leadboat(dot)com> wrote:
>
> If the build directory name contains a comma,
> src/test/modules/ssl_passphrase_callback fails on master since commit 4f43302.
> It fails because hba.c:next_token() treats a comma as a token separator:
Ugh, thanks for reporting.
> * Tokens can be delimited by double quotes (this allows the inclusion of
> * commas, blanks, and '#', but not newlines). As in SQL, write two
> * double-quotes to represent a double quote.
>
> Commit 4f43302 documented the pg_hosts.conf hostname field as a
> comma-separated list, but not the other fields. Should other pg_hosts.conf
> fields continue to require quoting around commas, or not?
Yes, only the hostname field is a comma-separated list. I think this should be
added to the documentation as well on top of the test fix in your patch. Do
you want me to take care of both parts?
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2026-04-26 21:54:25 | Re: Separators in pg_hosts.conf fields |
| Previous Message | Noah Misch | 2026-04-26 21:32:52 | Separators in pg_hosts.conf fields |